#3071: create new directory setting and use for '-d' parameter #3120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Sep 13, 2017
| @@ -158,6 +161,10 @@ object Settings { | |||
| case Success(v) => update(v, args) | |||
| case Failure(ex) => fail(ex.getMessage, args) | |||
| } | |||
| case (DirectoryTag, arg :: args) => | |||
| val path = Path(arg) | |||
| if (path.isDirectory) update(arg, args) | |||
There was a problem hiding this comment.
Here, it should be update(path.toDirectory, args)
| @@ -17,7 +18,7 @@ class ScalaSettings extends Settings.SettingGroup { | |||
| val javaextdirs = PathSetting("-javaextdirs", "Override java extdirs classpath.", Defaults.javaExtDirs) | |||
| val sourcepath = PathSetting("-sourcepath", "Specify location(s) of source files.", "") // Defaults.scalaSourcePath | |||
| val classpath = PathSetting("-classpath", "Specify where to find user class files.", defaultClasspath) withAbbreviation "-cp" | |||
| val d = StringSetting("-d", "directory|jar", "destination for generated classfiles.", ".") | |||
| val d = DirectorySetting("-d", "directory|jar", "destination for generated classfiles.", Directory(Path("."))) | |||
There was a problem hiding this comment.
We should probably rename this setting to something like outputDir
also make sure that directory exists
|
I've had to touch up the tests so that the output directory actually exists. |
|
Could you add a test under class SettingTests {
...
@Test def missingOutputDir: Unit = {
val options = Array("-d", "not_here")
val reporter = Main.process(options)
assertEquals(reporter.errorCount, 1)
assertEquals(reporter.allErrors.head.message, "'not_here' does not exist or is not a directory")
}
} |
|
Sure thing! |
|
Nitpick: To automatically close the issue when a PR is merged, you should put "Fix #nnnn" in the commit message, just putting "#nnnn" is not enough. |
|
Thanks for the nitpicking! I've updated the last commit comment, I hope that suffices. |
allanrenucci
approved these changes
Sep 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also make sure that directory exists when updating setting